Feature#19 RDB 테이블에 기반한 FSD 의 entities/*/schema 구성#22
Merged
Conversation
Contributor
Author
서버 응답에 대한 ZOD Schema 가 필요할까요 ?
|
Contributor
|
전체적으로 entities 별로 타입을 잡아둔 방향은 좋은 것 같습니다! 다만 현재 구현은 런타임 스키마가 아니라 TS 타입(interface) 정의라서 Schema 네이밍이 오해 소지가 있을 것 같습니다.
|
eunwoo-levi
reviewed
Dec 15, 2025
| export interface UserSchema { | ||
| id: number; | ||
| email: string; | ||
| role: "NORMAL" | "ADMIN"; |
Contributor
There was a problem hiding this comment.
role은 UserRole 타입으로 분리하면 재사용성과 가독성이 좋아질 것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1️⃣ PR 타입 (PR Type)
2️⃣ 변경 사항 (Changes)
3️⃣ 관련 이슈 (Related Issues)
✅ 체크리스트 (Checklist)
base branch를 확인했나요?self-review를 진행했나요?