Added snap installation support#39
Open
BoskyWSMFN wants to merge 1 commit into
Open
Conversation
abn
reviewed
Sep 27, 2025
|
|
||
| class TailscaleApiClient { | ||
| constructor() { | ||
| const nativePath = "/var/run/tailscale/tailscaled.sock"; |
There was a problem hiding this comment.
Might be a good idea to use a list of values and iterate over them instead of hard coding cases. This way we can simply add "well known" paths later for anything else.
Alternatively (likely a separate PR) would even be great to be able to move this to a configuration setting that users can set.
Author
There was a problem hiding this comment.
Well, the idea with a list might be good for custom tailscale builds, yes, but this PR is just a quick fix for my specific case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR improves compatibility of the extension by allowing it to detect and use the correct tailscaled.sock socket path automatically, depending on how Tailscale is installed:
/var/run/tailscale/tailscaled.sock/var/snap/tailscale/common/socket/tailscaled.sockThe
TailscaleApiClientconstructor now: