Skip to content

Commit

Permalink
cert info indicators removal (kiali#823)
Browse files Browse the repository at this point in the history
  • Loading branch information
leandroberetta authored Sep 27, 2024
1 parent ea12b9d commit 8ef0da3
Show file tree
Hide file tree
Showing 13 changed files with 0 additions and 215 deletions.
3 changes: 0 additions & 3 deletions DEVELOPING.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,7 @@ NOTE: If you have never run the Molecule tests before, the Molecule container im
- [ ] Update the golden copy of the link:./manifests/kiali-upstream[kiali-upstream CSV metadata] (_* **see link:#maintain-backward-compatibility[note] above**_)
- [ ] Update the golden copy of the link:./manifests/kiali-community[kiali-community CSV metadata] (_* **see link:#maintain-backward-compatibility[note] above**_)
- [ ] Update the golden copy of the link:./manifests/kiali-ossm/manifests/kiali.clusterserviceversion.yaml[kiali-ossm CSV metadata] (_* **see link:#maintain-backward-compatibility[note] above**_)
- [ ] Update the link:./roles/default/kiali-deploy/templates/kubernetes/role-controlplane.yaml[Operator Kubernetes role-controlplane.yaml]
- [ ] Update the link:./roles/default/kiali-deploy/templates/openshift/role-controlplane.yaml[Operator OpenShift role-controlplane.yaml]
- [ ] Update the link:https://github.com/kiali/helm-charts/tree/master/kiali-operator/templates/clusterrole.yaml[Operator Helm Chart clusterrole.yaml]
- [ ] Update the link:https://github.com/kiali/helm-charts/tree/master/kiali-server/templates/role-controlplane.yaml[Server Helm Chart role-controlplane.yaml]
### Are You Altering a Kiali Server Configuration Setting?

Expand Down
5 changes: 0 additions & 5 deletions crd-docs/cr/kiali.io_v1alpha1_kiali.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -407,11 +407,6 @@ spec:
version_label_name: "version"

kiali_feature_flags:
certificates_information_indicators:
enabled: true
secrets:
- "cacerts"
- "istio-ca-secret"
disabled_features: []
istio_annotation_action: true
istio_injection_action: true
Expand Down
10 changes: 0 additions & 10 deletions crd-docs/crd/kiali.io_kialis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1141,16 +1141,6 @@ spec:
description: "Kiali features that can be enabled or disabled."
type: object
properties:
certificates_information_indicators:
description: "Flag to enable/disable displaying certificates information and which secrets to grant read permissions."
type: object
properties:
enabled:
type: boolean
secrets:
type: array
items:
type: string
disabled_features:
description: "There may be some features that admins do not want to be accessible to users (even in 'view only' mode). In this case, this setting allows you to disable one or more of those features entirely."
type: array
Expand Down
48 changes: 0 additions & 48 deletions molecule/read-certs-secrets-test/converge.yml

This file was deleted.

20 changes: 0 additions & 20 deletions molecule/read-certs-secrets-test/kiali-cr.yaml

This file was deleted.

46 changes: 0 additions & 46 deletions molecule/read-certs-secrets-test/molecule.yml

This file was deleted.

2 changes: 0 additions & 2 deletions roles/default/kiali-deploy/tasks/kubernetes/k8s-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@
- "templates/kubernetes/serviceaccount.yaml"
- "templates/kubernetes/configmap.yaml"
- "templates/kubernetes/{{ 'role-viewer' if ((kiali_vars.deployment.view_only_mode|bool == True) or (kiali_vars.auth.strategy != 'anonymous')) else 'role' }}.yaml"
- "templates/kubernetes/role-controlplane.yaml"
- "templates/kubernetes/rolebinding.yaml"
- "templates/kubernetes/rolebinding-controlplane.yaml"
- "templates/kubernetes/deployment.yaml"
- "templates/kubernetes/service.yaml"
- "{{ 'templates/kubernetes/hpa.yaml' if kiali_vars.deployment.hpa.spec | length > 0 else '' }}"
Expand Down
2 changes: 0 additions & 2 deletions roles/default/kiali-deploy/tasks/openshift/os-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@
- "templates/openshift/configmap.yaml"
- "templates/openshift/cabundle.yaml"
- "templates/openshift/{{ 'role-viewer' if ((kiali_vars.deployment.view_only_mode|bool == True) or (kiali_vars.auth.strategy != 'anonymous')) else 'role' }}.yaml"
- "templates/openshift/role-controlplane.yaml"
- "templates/openshift/rolebinding.yaml"
- "templates/openshift/rolebinding-controlplane.yaml"
- "{{ 'templates/openshift/clusterrole-oauth.yaml' if kiali_vars.auth.strategy == 'openshift' else '' }}"
- "{{ 'templates/openshift/clusterrolebinding-oauth.yaml' if kiali_vars.auth.strategy == 'openshift' else '' }}"
- "templates/openshift/deployment.yaml"
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

11 changes: 0 additions & 11 deletions roles/default/kiali-remove/tasks/resources-to-remove.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,3 @@ metadata:
namespace: "{{ kiali_vars_remove.deployment.namespace }}"
name: {{ kiali_vars_remove.deployment.instance_name }}
---
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
namespace: "{{ kiali_vars_remove.istio_namespace }}"
name: {{ kiali_vars_remove.deployment.instance_name }}-controlplane
---
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
namespace: "{{ kiali_vars_remove.istio_namespace }}"
name: {{ kiali_vars_remove.deployment.instance_name }}-controlplane

0 comments on commit 8ef0da3

Please sign in to comment.