Upgrade for Rails 7.1 #203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmazzi Hi, sorry to bother you, any chances to review and release new version of gem? Tests are passing locally |
|
@jmazzi could you merge it if it looks good for you |
|
@jmazzi please release the Rails 7.0.x gem version (right now only works with Rails 7 but not for 7.0.x) before this Rails 7.1 gem version |
|
This MR will support all 7.x versions. Is this desired that it will already support the upcoming Rails 7.2 release? |
|
@johan-smits thanks, makes sense, downgraded dependency to exclude 7.2 |
|
@jmazzi Sorry for disturbing you, could you help review this PR? Thanks in advance. |
|
@jmazzi bumping this now that it's idled for a few months 🙏 any chance you could review please? |
|
Also prepared PR for Rails 7.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated public/private keys, I'm not sure why they stopped working, maybe they expired. So I generated new with 50 years expiration.