Skip to content

Commit

Permalink
Fix pass? method
Browse files Browse the repository at this point in the history
  • Loading branch information
jlurena committed Nov 1, 2024
1 parent af8e696 commit f639735
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/jmeter_perf/report/comparator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def initialize(base_report, test_report, name = nil)
# @return [Boolean] true if comparison meets the criteria
def pass?(cohens_d_limit: nil, effect_size: :vsmall, direction: :both)
limit = cohens_d_limit || EFFECT_SIZE_LIMITS[effect_size]
raise ArgumentError, "Invalid effect size: #{effect_size}" unless cohens_d_limit
raise ArgumentError, "Invalid effect size: #{effect_size}" unless limit

raise ArgumentError, "Invalid direction: #{direction}" unless EFFECT_SIZE_DIRECTION.include?(direction)

Expand Down

0 comments on commit f639735

Please sign in to comment.