Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve collection, separate from ar model #3

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Improve collection, separate from ar model #3

merged 5 commits into from
Dec 20, 2024

Conversation

jlurena
Copy link
Owner

@jlurena jlurena commented Dec 20, 2024

No description provided.

@jlurena jlurena force-pushed the version0.1.4 branch 5 times, most recently from cdff376 to 04d8d78 Compare December 20, 2024 15:48
Repository owner deleted a comment from github-actions bot Dec 20, 2024
Repository owner deleted a comment from github-actions bot Dec 20, 2024
Repository owner deleted a comment from github-actions bot Dec 20, 2024
@jlurena jlurena force-pushed the version0.1.4 branch 5 times, most recently from f69664a to 7147205 Compare December 20, 2024 16:24
@jlurena jlurena force-pushed the version0.1.4 branch 9 times, most recently from 9a5c6da to bb003db Compare December 20, 2024 18:29
Repository owner deleted a comment from github-actions bot Dec 20, 2024
Repository owner deleted a comment from github-actions bot Dec 20, 2024
Repository owner deleted a comment from github-actions bot Dec 20, 2024
Repository owner deleted a comment from github-actions bot Dec 20, 2024
Repository owner deleted a comment from github-actions bot Dec 20, 2024
Repository owner deleted a comment from github-actions bot Dec 20, 2024
Repository owner deleted a comment from github-actions bot Dec 20, 2024
Repository owner deleted a comment from github-actions bot Dec 20, 2024
Repository owner deleted a comment from github-actions bot Dec 20, 2024
Repository owner deleted a comment from github-actions bot Dec 20, 2024
Repository owner deleted a comment from github-actions bot Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

TestsPassed ✅SkippedFailed
Test Result for Ruby:3.3500 ran500 passed0 skipped0 failed
No test annotations available

Copy link
Contributor

github-actions bot commented Dec 20, 2024

TestsPassed ✅SkippedFailed
Test Result for Ruby:3.2500 ran500 passed0 skipped0 failed
No test annotations available

Copy link
Contributor

github-actions bot commented Dec 20, 2024

TestsPassed ✅SkippedFailed
Test Result for Ruby:head500 ran500 passed0 skipped0 failed
No test annotations available

Repository owner deleted a comment from github-actions bot Dec 20, 2024
@jlurena jlurena merged commit a90091d into main Dec 20, 2024
8 checks passed
@jlurena jlurena deleted the version0.1.4 branch December 20, 2024 22:28
private

def request_resources!
return @elements if requested? || resource_class.nil?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when is the resource_class nil?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when initializing the model and not assigning resource_class . Its an attribute not in the constructor args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants