Curl output feature #737
Open
Curl output feature #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Python 2 compatibility pattern of encoding file paths to UTF-8 bytes before passing to os.path.exists(), os.stat(), open(), etc. These functions work directly with strings in Python 3. - Fix bug where headers dict was overwritten instead of updated when adding Range header for resume, which would lose existing headers. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Adds global CLI options to output curl commands for debugging: - --print-curl: prints curl command with auth redacted - --print-curl-auth: prints curl command with full auth (exposes secrets) Metadata GETs are executed (needed to construct subsequent requests), all other requests print the curl command and exit without executing. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Raises ItemLocateError early in modify_metadata when: - Item is dark (is_dark=True) - Item does not exist (exists=False) This prevents confusing KeyError exceptions when trying to build a metadata patch from incomplete item data. Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add changelog entries for curl output feature, files.py fixes, and dark item check - Fix line length in CLAUDE.md (102, not 90) - Add note about updating HISTORY.rst for changes Co-Authored-By: Claude Opus 4.5 <[email protected]>
Tests cover: - Basic curl command generation - Auth redaction (headers and body) - --compressed flag with Accept-Encoding - Binary body handling Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.