Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: pass through exclusive tenant tag #241

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aaronkvanmeerten
Copy link
Member

No description provided.

@@ -403,7 +403,22 @@ backend release-{{ release }}
{%- endif %}
{% endfor %}
{% for item in haproxy_facts.backends|sort(attribute='local',reverse=True) %}
{% if item['release_number'] != release %}
{% if item['release_number'] != release and item['exclusive_tenant'] == "" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the new logic for when the item['exclusive_tenant'] != "" not item['exclusive_tenant'] == "" ?
I don't completely understand it, that's why I'm not sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have replaced one loop for two. Previously, we'd loop on all shards in releases that don't match the current one. Now we loop on all shards that don't match the current release and don't have an exclusive tenancy. Then we go back and loop again and include any that have an exclusive tenancy but aren't part of the current release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants