Support fixture directory search #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aatishnn
force-pushed
the
aatish/support-fixture-search
branch
4 times, most recently
from
cc636b1 to
a8ad93e
Compare
aatishnn
force-pushed
the
aatish/support-fixture-search
branch
from
a8ad93e to
9c1c447
Compare
jimjkelly
reviewed
Dec 17, 2024
| @fixture | ||
| def value_at_conftest(): | ||
| return 43 |
There was a problem hiding this comment.
What's the intended difference between this and the above?
| @@ -51,39 +141,40 @@ pub fn run_tests(rx: mpsc::Receiver<TestCase>, tx: mpsc::Sender<TestCase>) -> Re | |||
| // Prepare a vector to hold the generators to run after the fixture is called | |||
| let mut generators: Vec<Py<PyAny>> = Vec::new(); | |||
|
|
|||
| //println!("File path, current_dir: {:?}, {:?}", path, current_dir); | |||
|
|
||
| // Begin directory traversal | ||
| loop { | ||
| //n!("Checking directory for fixture {}: {:?}", fixture_name, current_path); |
There was a problem hiding this comment.
probably worth purging, or we can maybe make a verbosity level (I forget if we have that) and log this sort of stuff on high verbosity levels?
| if let Ok(content) = fs::read_to_string(file_path) { | ||
| let def_pattern = format!("def {}(", fixture_name); | ||
| let fixture_pattern = format!("fixture(name=\"{}\")", fixture_name); | ||
| return content.contains(&def_pattern) || content.contains(&fixture_pattern); |
There was a problem hiding this comment.
Would this capture any function that matches the name?
Should it instead validate either of the two patterns, and if it's the first, validate it has a fixture decorator?
Also do we think this might benefit from the AST pattern we use elsewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic support for traversing directories upwards to find fixtures similar to how pytest does.