Ensure disabled tasks return full tuple & fix public‐dataset filter#23
Open
LudovicTuncay wants to merge 2 commits intojimbozhang:mainfrom
Open
Ensure disabled tasks return full tuple & fix public‐dataset filter#23LudovicTuncay wants to merge 2 commits intojimbozhang:mainfrom
LudovicTuncay wants to merge 2 commits intojimbozhang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two related bugs in task scoring:
Disabled‐task return shape
config.disabled == True,worker()returned a 3-tuple(formal_name, (0,0), (0,0)). Downstream code always expected a 4-tuple(formal_name, mlp_score, knn_score, private_flag), causing an index-out-of-range error when building the DataFrame.
(formal_name, (0,0), (0,0), config.private)so the shape isconsistent in all cases.
Public‐dataset filter logic
v[-1] == True, butv[-1]is actually the
privateflag. That made “public” averages include only private tasks.if v[-1] == Falseso that only non-private (public)tasks are aggregated.
Both fixes are split into two commits for clarity. All existing tasks (and any new ones) should now pass without index errors, and the “public” averages reflect the intended data.