Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : Show/Hide delete button #29

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat : Show/Hide delete button #29

wants to merge 6 commits into from

Conversation

tu2-atmanand
Copy link

  • A new setting option added for user to select whether they want to see the delete button in the card's footer.
  • The feature has been implemented in the component file.

@tu2-atmanand tu2-atmanand mentioned this pull request Dec 12, 2024
Open
jillro
jillro requested changes Dec 13, 2024
View reviewed changes
Copy link
Owner

@jillro jillro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! There are just a few changes that seem to not be linked with the feature and should be removed.

src/components/Card.svelte Outdated Show resolved Hide resolved
jillro
jillro requested changes Dec 17, 2024
View reviewed changes
Copy link
Owner

@jillro jillro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on main and push -f to run linting checks, and we're good to merge !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillro jillro jillro requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tu2-atmanand @jillro