Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-3
to
+5
| class Config(): | ||
|
|
||
|
|
||
| class Config: |
Author
There was a problem hiding this comment.
Lines 3-27 refactored with the following changes:
- Replace list(), dict() or set() with comprehension (
collection-builtin-to-comprehension)
| async def _start(client, message): | ||
| update_channel = UPDATES_CHANNEL | ||
| if update_channel: | ||
| if update_channel := UPDATES_CHANNEL: |
Author
There was a problem hiding this comment.
Function _start refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-99
to
+98
| update_channel = UPDATES_CHANNEL | ||
| if update_channel: | ||
| if update_channel := UPDATES_CHANNEL: |
Author
There was a problem hiding this comment.
Function _help refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-152
to
-167
| if(pos==1): | ||
| button = [ | ||
| [InlineKeyboardButton(text = '-->', callback_data = "help+2")] | ||
| ] | ||
| elif(pos==len(tr.HELP_MSG)-1): | ||
| button = [ | ||
| [InlineKeyboardButton(text = '<--', callback_data = f"help+{pos-1}")] | ||
| if (pos==1): | ||
| return [[InlineKeyboardButton(text='-->', callback_data="help+2")]] | ||
| elif (pos==len(tr.HELP_MSG)-1): | ||
| return [ | ||
| [InlineKeyboardButton(text='<--', callback_data=f"help+{pos-1}")] | ||
| ] | ||
| else: | ||
| button = [ | ||
| return [ | ||
| [ | ||
| InlineKeyboardButton(text = '<--', callback_data = f"help+{pos-1}"), | ||
| InlineKeyboardButton(text = '-->', callback_data = f"help+{pos+1}") | ||
| InlineKeyboardButton( | ||
| text='<--', callback_data=f"help+{pos-1}" | ||
| ), | ||
| InlineKeyboardButton( | ||
| text='-->', callback_data=f"help+{pos+1}" | ||
| ), | ||
| ], | ||
| ] | ||
| return button |
Author
There was a problem hiding this comment.
Function map refactored with the following changes:
- Lift return into if (
lift-return-into-if)
Comment on lines
20
to
21
| # this is a dirty way for the work-around required for #23 | ||
| print("DATABASE_URL is not configured. Features depending on the database might have issues.") | ||
| print(str(e)) No newline at end of file | ||
| print(e) No newline at end of file |
Author
There was a problem hiding this comment.
Lines 21-21 refactored with the following changes:
- Remove unnecessary call to
str()withinprint()(remove-str-from-print)
| def disapprove(chat_id): | ||
| rem = SESSION.query(forceSubscribe).get(chat_id) | ||
| if rem: | ||
| if rem := SESSION.query(forceSubscribe).get(chat_id): |
Author
There was a problem hiding this comment.
Function disapprove refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!