support for multiple statements per file#8
Open
ironfist wants to merge 2 commits intojhollingworth:masterfrom
Open
support for multiple statements per file#8ironfist wants to merge 2 commits intojhollingworth:masterfrom
ironfist wants to merge 2 commits intojhollingworth:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OFX supports the ability to have multiple statements from multiple accounts per file. As-is the OFXSharp project only grabs the first account's data. This edit moves some of the OFXDocument properties to a new Statement class, creates a new Statements property on OFXDocument class, and localizes the XPath queries to the statement node (instead of global).