-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Pptx reader added #11286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Pptx reader added #11286
Conversation
aantich
commented
Nov 9, 2025
- Read pptx format
- Parse "smart art" diagrams
- smart list detection
.gitignore
Outdated
| /test-docs | ||
| doc/pptx-reader-design-v2.md | ||
| doc/pptx-reader-design.md | ||
| doc/xlsx-reader-design.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These .gitignore changes are specific to your setup and probably shouldn't be included in the PR.
.gitignore
Outdated
| doc/pptx-reader-design*.md | ||
| doc/xlsx-reader-design.md | ||
| test-docs/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
|
Thanks for the PR! I'm testing it locally, and here are two things I noticed. Slide titlesPandoc normally uses headings with the slide title, but these get replaced by the pptx reader with "Slide 1", "Slide 2" etc. Can this be fixed? Missing p:sldIdListWhen I generate pandoc's default But the file opens just fine in PowerPoint; I think it is valid, hence that p:sldIdLst may be optional? Can we handle the case where it is missing? |
|
thank you, on it |
|
In addition, the new format should be added to MANUAL.txt ; see the list under --readers. |
|
Addressed all comments. |
|
Tests are failing - can you fix? |
|
Hi, just wanted to see if you're planning to finish polishing this up. I think the CI test failure is something trivial; this is close to being mergeable. |