Fixed an issue where plot_pfss()-method would crash with reference_lo…#95
Merged
jgieseler merged 1 commit intojgieseler:mainfrom Feb 13, 2026
Merged
Fixed an issue where plot_pfss()-method would crash with reference_lo…#95jgieseler merged 1 commit intojgieseler:mainfrom
jgieseler merged 1 commit intojgieseler:mainfrom
Conversation
…n==int(0). Also fixed a minor bug where pfss_table would display the latitudinal separation between reference and the Earth as the Earth's magnetic footpoint if no reference latitude was given.
Contributor
Author
|
This pull request is a fix to issue #94. |
Owner
But now this is only fixed for the latitude; the longitude still shows the old behavior, right? And that would be crashing, because ref_earth_sep_lon = earth_footpoint[0] - self.reference_long if earth_footpoint[0] - self.reference_long < 180 else earth_footpoint[0] - self.reference_long - 360will cause a |
Contributor
Author
|
No, it will not, because that line is never executed if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n==int(0). Also fixed a minor bug where pfss_table would display the latitudinal separation between reference and the Earth as the Earth's magnetic footpoint if no reference latitude was given.