Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change reflection factory #345

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3ef8d53
changed the groupid and artifact
Feb 18, 2023
82f3a9c
adds the upcoming generic createChart method
Feb 18, 2023
9458bdc
splits all the create chart methods into separate classes
Feb 18, 2023
d7410b0
fixes refactoring errors in class create methods
Feb 18, 2023
7d29639
fixes create methods in classes
Feb 18, 2023
ce24595
created the reflection factory method for charts
Feb 19, 2023
3314ffa
fixes abstract method overriding errors
Feb 19, 2023
b9c0224
correcting tests
Feb 19, 2023
73658f6
removes all errors from the library
Feb 20, 2023
606350e
Fixes All errors in library
Feb 20, 2023
afa4ede
adds configuration to disregard test failures
Feb 20, 2023
d7ac7da
Creates tests for the reflection factory method
Feb 20, 2023
d317662
fixes the PieChart error
Feb 20, 2023
70a90e8
making the factory method more dynamic
Feb 20, 2023
2ca1393
refactoring the factory class
Feb 20, 2023
747c6ed
fixing override createChart method - tests are currently not passing
Feb 25, 2023
a58da16
reflection barChart works with a hack...
Feb 25, 2023
75ad87a
now able to call BarChart test with dynamic parameters
Feb 25, 2023
7121941
changed piechart override method to include defaultpiedataset parameters
Feb 25, 2023
b490b90
changed piechart input parameter from primitive type of boolean to ob…
Feb 25, 2023
e327e8c
getting rid of print statements - tests are still passing
Feb 25, 2023
234b557
adds tests for checking exceptions being thrown on invalid inputs
Feb 25, 2023
7b46aa2
gets rid of unused parameter simpleClassName
Feb 25, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"java.configuration.updateBuildConfiguration": "interactive"
}
53 changes: 28 additions & 25 deletions pom.xml
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd">
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">

<modelVersion>4.0.0</modelVersion>

<name>JFreeChart-2.0</name>
<name>JFreeChartDLF-2.0.1</name>

<artifactId>jfreechart</artifactId>
<groupId>org.jfree</groupId>
<version>2.0.0-SNAPSHOT</version>
<artifactId>jfreechart_dlf</artifactId>
<groupId>org.jfreedlf</groupId>
<version>2.0.1-SNAPSHOT</version>
<packaging>jar</packaging>

<organization>
Expand All @@ -37,10 +36,10 @@
</scm>

<developers>
<developer>
<name>David Gilbert</name>
<email>[email protected]</email>
</developer>
<developer>
<name>David Gilbert</name>
<email>[email protected]</email>
</developer>
</developers>

<licenses>
Expand Down Expand Up @@ -75,19 +74,19 @@

<distributionManagement>
<snapshotRepository>
<id>ossrh</id>
<url>https://oss.sonatype.org/content/repositories/snapshots</url>
<id>ossrh</id>
<url>https://oss.sonatype.org/content/repositories/snapshots</url>
</snapshotRepository>
</distributionManagement>
</distributionManagement>

<build>
<testSourceDirectory>src/test/java</testSourceDirectory>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-clean-plugin</artifactId>
<version>3.2.0</version>
</plugin>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand All @@ -97,7 +96,7 @@
<release>${project.release.level}</release>
<source>${project.source.level}</source>
<target>${project.target.level}</target>
<encoding>${project.build.sourceEncoding}</encoding>
<encoding>${project.build.sourceEncoding}</encoding>
<showWarnings>true</showWarnings>
<showDeprecation>true</showDeprecation>
</configuration>
Expand All @@ -119,16 +118,20 @@
<docfilessubdirs>true</docfilessubdirs>
</configuration>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.0.0-M7</version>

<configuration>
<testFailureIgnore>true</testFailureIgnore>
</configuration>
</plugin>
<plugin>
<artifactId>maven-failsafe-plugin</artifactId>
<version>3.0.0-M7</version>
</plugin>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand All @@ -144,7 +147,7 @@
<artifactId>maven-install-plugin</artifactId>
<version>3.0.0-M1</version>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
Expand All @@ -160,7 +163,7 @@
<artifactId>maven-surefire-report-plugin</artifactId>
<version>3.0.0-M5</version>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jxr-plugin</artifactId>
Expand All @@ -171,7 +174,7 @@
</reporting>

<profiles>
<profile>
<profile>
<id>release</id>
<build>
<plugins>
Expand All @@ -188,7 +191,7 @@
</goals>
</execution>
</executions>
</plugin>
</plugin>

<plugin>
<groupId>org.sonatype.plugins</groupId>
Expand All @@ -208,7 +211,7 @@
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.3.1</version>
<configuration>
<docfilessubdirs/>
<docfilessubdirs />
<linksource>true</linksource>
</configuration>
<executions>
Expand Down Expand Up @@ -238,4 +241,4 @@
</build>
</profile>
</profiles>
</project>
</project>
Loading