Move self_greater to the is_greater callable #2055
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SadiinsoSnowfall
force-pushed
the
callable/cmp-gt
branch
from
ba039b2 to
d0cff16
Compare
SadiinsoSnowfall
force-pushed
the
callable/cmp-gt
branch
from
aa6b3af to
42270f7
Compare
| // static_assert( valid_tolerance<common_value_t<T, U>, Options>::value, "[eve::is_greater] simd tolerance requires at least one simd parameter." ); | ||
| } | ||
|
|
||
| return EVE_DISPATCH_CALL(a, b); | ||
| } |
There was a problem hiding this comment.
I'm waiting for the impl file to be inline. Apparently that shows some issues.
There was a problem hiding this comment.
I'm working on it, there is some issue with circular dependencies but it should be solved by tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a small fix for the
is_lesscodegen on SSE4.2