Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Seems like currently
Chroma::Color
generates wrong RGB from HEX8. Here is a proof that#eb09b9c4
has to be235, 9, 185
:But
Chroma::Color#rgb
returns9, 185, 196
:Solution:
I have found a six years old issue #6, that was resolved by replacing the order of arguments for
FromHexStringValues#from_hex8
method. I have moved it back and now it returns expected RGB: