fix(根据ID查询属性值命令): 优化 #103
Open
fix(根据ID查询属性值命令): 优化 #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhou-hao
reviewed
Sep 12, 2025
| public String getId() { | ||
| return super.getId(); | ||
| return Optional.ofNullable(super.getId()) | ||
| .orElseThrow(() -> new IllegalArgumentException("设备ID不能为空")); |
Member
There was a problem hiding this comment.
1.使用ValidationException
2. 国际化
zhou-hao
reviewed
Sep 13, 2025
| public String getId() { | ||
| return Optional.ofNullable(super.getId()) | ||
| .orElseThrow(() -> new IllegalArgumentException("设备ID不能为空")); | ||
| .orElseThrow(() -> new ValidationException.NoStackTrace(LocaleUtils.resolveMessage("device.queryPropertyLatestCommand.param.error"))); |
Member
There was a problem hiding this comment.
new ValidationException.NoStackTrace("id","validation.NotNull.deviceId")
zhou-hao
reviewed
Sep 14, 2025
| public String getId() { | ||
| return super.getId(); | ||
| return Optional.ofNullable(super.getId()) | ||
| .orElseThrow(() -> new ValidationException.NoStackTrace("id", LocaleUtils.resolveMessage("validation.NotNull.deviceId"))); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zhou-hao