Add EventStoreSource #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CumpsD
reviewed
Jan 29, 2020
| startMode, spec.groupName, startPos.CommitPosition, Reader.chunk startPos, float startPos.CommitPosition/float maxPos.CommitPosition, | ||
| checkpointFreq.TotalMinutes) | ||
| return startPos } | ||
| let cosmosIngester = sink.StartIngester(log.ForContext("Tranche","Ingester"), 0) |
There was a problem hiding this comment.
is this a typo, or does the EventStoreSource really need Cosmos?
There was a problem hiding this comment.
Good catch - before it was generalized to sync to/from ES/Cosmos, the original impl was indeed ES->Cosmos. ingester would be a better name, as really all a source does is feed into an ingester. (TMI: an ingester feeds to a scheduler - which then dispatches to a handler (which might be a sink if the task is to maintain a live sync between two event storage systems))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This derives from a set of work carried out in this long-running
dotnet-templatesPR, which spawned a lot of code that resides in this repo today.