minimal example

[dzmitry-lahoda]

What can be wrong (just complaining, no so important):

• the need to open Confluent.Kafka, longer one liner
• Replacing ProduceAsync with Produce may appear for more proper-modern-expected API
• need to create logger, allow for default null logger

[bartelink]

very nice, thanks!

the need to open Confluent.Kafka, longer one liner

If you're referring to having 2 namespaces, I think its valuable to use CK stuff as much as possible and not overload (which was def not the philosophy in v 0.x of this lib). By and large, CK 1.x is getting very complete in terms of config stuff so I'd venture that requiring it is pretty normal.

In general, I'd suggest opening CK and then having explicit FsKafka prefixes where required so it stands out

Replacing 'ProduceAsyncwithProduce` may appear for more proper-modern-expected API

CK 1.x tends to expose async and sync, so this is following the pattern. I agree that removing might not be a bad idea, but that'd need to be a 2.x thing

added to #48

need to create logger, allow for default null logger

the opinionated choice of coupling to a concrete logger is not something that I feel should be hidden so this is a "by design"

[bartelink]

Let me know when you're ready for me to (squash-) merge (and confirm this supersedes #46 by closing same)

[dzmitry-lahoda]

I assume F# is next Python in some areas. Pythonist could expect single namespace and default logger I guess. So opinion to ensure Data Engineering and Data Science flows got into F# in oneliners in next several years.

[bartelink]

There's [vain] hope in some quarters ;)

We could generalize to a M.E.L based dep, but it would still need to be fulfilled, and I have stuff e.g. in FsKafka that includes deep structures that come out cleaner in a json log when you use Destructurama.FSharp alongside. I'm not against that happening in FsKafka, Propulsion and Equinox but

a) if one does it, they should all do it (depend on MEL and use more boring types e.g. no options, must be Nullable etc)
b) we'd need to find someone in 2020 that's still thinking NLog and NUnit are the way to go!