-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore: migrate resolve
and resolve.exports
to unrs-resolver
#15619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
d892bb9
to
c7d496e
Compare
@SimenB Should we drop |
7bb7369
to
0b753f5
Compare
That seems fine to me. But I'm also wondering if no Mind updating the docs as well? Lines 1469 to 1546 in 4556297
|
I can try to help adding it a new feature for
Or is there any difference between
There is no
Sure after codes accepted. |
I'll add |
Wow, awesome, thanks for working on this @JounQin. I assume this should have a noticeably positive perf impact on Jest. Would you be able to share the performance before and after this change of running Jets's own test suite? (First Note that benchmarking should also use |
0b753f5
to
3d9595c
Compare
3d9595c
to
45df461
Compare
There are still a few test cases failing, I'll check verify if can it be fixed in |
For performance benchmarking, before: 7m18s, after: 6m31s.
|
Summary
close #15600
Test plan
There are already related test cases.