chore: update type tests #15569
Merged
chore: update type tests #15569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
mrazauskas
commented
Apr 10, 2025
Comment on lines
+357
to
360
| expect(mockFn.withImplementation(mockFnImpl, () => {})).type.toBe<void>(); | ||
| expect(mockFn.withImplementation(mockFnImpl, async () => {})).type.toBe< | ||
| Promise<void> | ||
| >(); |
There was a problem hiding this comment.
For instance, here and in other similar places the code is easer to read when .toBe() used. At least I think so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Primitive type matchers like
.toBeString()or.toBeBoolean()will be removed in the next major TSTyche release. Reference: https://tstyche.org/releases/tstyche-4#matchersThis PR is replacing them with
.toBe().The primitive type were adding bloat to the code base and did not look needed anyhow. For example, if some behaviour is changing it is easier to move from
.toBe<string>()to.toBe<Promise<string>>(). It was not clear why using.toBeString()is anyhow better.Test plan
Green CI.