Skip to content

feat(draft): custom folder to avoid repetitions with __mocks__ #14338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat(draft): custom folder to avoid repetitions with __mocks__ #14338

wants to merge 3 commits into from
+26 −4

Conversation

scarletquasar
Copy link

@scarletquasar scarletquasar commented Jul 18, 2023 •
edited
Loading

Summary

Implement customMocks folder feature to avoid __mocks__ folder repetition in monorepos or similar situations (see issue #13647).

Work in progress.

Test plan

  • current tests are passing
  • add units tests
  • add e2e tests
  • add type tests
  • documentation

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 18, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Jul 18, 2023 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 30f5000
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64b61a9b5b901c000897545a
😎 Deploy Preview https://deploy-preview-14338--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@scarletquasar scarletquasar changed the title feat: custom folder to avoid repetitions with __mocks__ feat(draft): custom folder to avoid repetitions with __mocks__ Jul 18, 2023
noghartt
noghartt reviewed Jul 18, 2023
View reviewed changes
Copy link

@noghartt noghartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

packages/jest-resolve-dependencies/src/index.ts
'__mocks__',
);
// eslint-disable-next-line no-console
console.log(options?.customMockPath);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove this console.log?

Copy link
Author

@scarletquasar scarletquasar Jul 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a draft so I didn't remove these checkers yet

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, okay, nice

@scarletquasar
Copy link
Author

Just remembering that this PR is not forgotten. Im just having a though time in the work and my time is strictly limited.

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Aug 21, 2024
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this Sep 20, 2024
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2024
@SimenB SimenB reopened this Jan 19, 2025
@jestjs jestjs unlocked this conversation Jan 19, 2025
@SimenB
Copy link
Member

SimenB commented Jan 19, 2025

👋😅

I think this makes sense as an option 👍 Just needs some documentation I believe? (If you're still up for it)

@SimenB SimenB added Pinned and removed Stale labels Jan 19, 2025
@cpojer
Copy link
Member

cpojer commented May 22, 2025

Could you update this PR and update the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noghartt noghartt noghartt left review comments

Assignees
No one assigned
Labels
Pinned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scarletquasar @SimenB @cpojer @noghartt