Skip to content

fix: update vscode color to logo color #4459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PeterCardenas
Copy link
Contributor

  • PR Description
    The vscode folder color appears to be using the visual studio purple color which is different from the vscode blue color. This updates it using a color picker on the inner part of the logo.

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@stefanhaller
Copy link
Collaborator

Looks good, although according to this page it should be #007ACC (depending on which of the three blues you pick; I'd say the middle one probably makes the most sense).

@stefanhaller stefanhaller added the bug Something isn't working label Apr 10, 2025
@stefanhaller
Copy link
Collaborator

@PeterCardenas I didn't realize you had force-pushed the branch. Best to explicitly ping again in that case.

Thanks for changing; merging.

@stefanhaller stefanhaller merged commit 1106b67 into jesseduffield:master Apr 10, 2025
14 checks passed
@PeterCardenas
Copy link
Contributor Author

thanks for the advice, will do next time 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants