Fix display of renamed files in tree view #4452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renaming a file inside the same directory shows it with its full path in the tree view, which isn't what we want. We'll fix this in the next commit. Also adding a few other test cases for moving files; they show that the display of moved files in tree view isn't ideal. For example, moving file1 from top level into dir shows it as "R file1 → file1", which isn't distinguishable from renaming file1 inside dir. I suppose what we would like to have here is "R ../file1 → file1" or something, but I'll leave that for the future; here I only want to fix the regression that was introduced with the root item PR.
This broke with #4346 (Add root node in file tree).
stefanhaller
added
ignore-for-release
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression (introduced with the root item PR, #4346) that caused renamed files to be displayed with their full path in tree view.
While fixing this I noticed that the display of moved files is a bit confusing; for example, you can't distinguish a file being moved from the root level into a directory from one that was renamed inside the directory; see commit message of the first commit for more. I'm not doing anything about this right now, just fix the regression for now.
Labeled as "ignore-for-release" because it fixes a regression in code that wasn't released yet.
go generate ./...)