worktree: escape files that start with '#' or '!' while ignoring

[azarmadr]

• PR Description

• Please check if the PR fulfills these requirements

• Cheatsheets are up-to-date (run go generate ./...)
• Code has been formatted (see here)
• Tests have been added/updated (see here for the integration test guide)
• Text is internationalised (see here)
• If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
• Docs have been updated if necessary
• You've read through your own file changes for silly mistakes etc

fixes #4445

[stefanhaller]

This looks good, but I wonder if we can take this opportunity to also fix #4075. I imagine we could use a regex that catches all of these (something like ^[!#]|[\[\]\(\)]) and then use ReplaceAllString(filename, "#$1").

[azarmadr]

used string commands only, if that's ok

[stefanhaller]

used string commands only, if that's ok

But why, using a regex is much less code. Also, I would have expected a bit more research which other characters we need to escape that weren't mentioned in the issue (turns out we also need *), and adding a test would be good.

I found it easier to make these changes myself than to tell you what I would like to have added, so I opened a new PR for this.

Next time you make a PR, please create a branch instead of using the master branch of your fork. This would have allowed my to add these changes directly to your PR, and I wouldn't have had to open a new one.

[stefanhaller]

This has been addressed by #4475; closing.