feat: add short code alias for peer connection#12
Open
naremloa wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a temporary 6-character alias “peer” to make initial connection setup easier (especially for manual entry), while preserving the existing /#<full-peer-id> linking flow once the real connection is established.
Changes:
- Added alias generation helper with an unambiguous character set.
- Updated
Chatto (a) display a host code during setup and (b) resolve 6-char hashes as aliases before reconnecting via the real peer id. - Added connection timeout/error handling and alias-peer teardown hooks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/Service/ChatHelper.ts |
Adds generateAlias() to produce short, human-friendly setup codes. |
src/Chat.tsx |
Implements alias registration, alias-based join flow, UI for code display/input, and updated connect timeout/error behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Addressed the Copilot review feedback in 5760f2f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11
Adds a 6-character short code as an alternative to sharing the full peer ID during setup. The code only lives during the setup phase. Once the real connection is established, both sides switch to the primary peer ID and the short-code peer is torn down.
Expected behaviour:
they leave.
effectively single-use.
<domain>/#<full-peer-id>flow unchanged