fix: resolve CI issues #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
naorpeled
commented
Dec 31, 2024
•
naorpeled
commented
- added myself as maintainer
- resolved CI issues
- dropped Node 14 and 16 official support
bherila
approved these changes
Dec 31, 2024
|
Oh latest changes will fix it. |
forgot to push the actual fix :P |
|
@jeremydaly you decide if you want this as one thing, or if you want to do #162 first then do #163 on top for the readme changes. I have no preference |
bherila
reviewed
Dec 31, 2024
| on: | ||
| pull_request: | ||
| types: [opened, reopened, synchronize] | ||
| push: |
There was a problem hiding this comment.
Personally I think it's nice to keep this on push because I like having the status in the commit history
There was a problem hiding this comment.
Makes sense, adding it back now :)
naorpeled
force-pushed
the
fix/resolve-ci-issues
branch
from
2a91672 to
90d1f6a
Compare
Co-authored-by: Ben Herila <[email protected]>
naorpeled
force-pushed
the
fix/resolve-ci-issues
branch
from
90d1f6a to
f9fc8af
Compare
|
@bherila addressed your comments, WDYT? |
|
I see no problems with anything in here. I defer to @jeremydaly however :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.