Skip to content

Conversation

@de-sec
Copy link

@de-sec de-sec commented Jun 3, 2022

Unexpected quotation mark breaks the Plugins Page of Kimai (HTTP 500; PHP Array Issue)

Copy link
Owner

@jens-2305 jens-2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jens-2305 looks good to me, what about merging?

Migrated Code and added Workaround for ExportContext.php in Readme
@de-sec
Copy link
Author

de-sec commented Oct 2, 2023

Additional Update to Migrate to Kimai2 V2 (including Workaround for ExportContext.php from Kimai2 V1 in Readme)

@kevinpapst
Copy link

DON'T recommend this please.

This is what you are looking for:
https://github.com/kimai/kimai/blob/main/src/Pdf/PdfContext.php

de-sec added 2 commits October 2, 2023 16:07
Migration ExportContext to PdfContext as suggested by @kevinpapst in jens-2305#2 (comment)
@de-sec
Copy link
Author

de-sec commented Oct 2, 2023

DON'T recommend this please.

This is what you are looking for: https://github.com/kimai/kimai/blob/main/src/Pdf/PdfContext.php

@kevinpapst Thanks for the Feedback, edited files according to your recommendations

Copy link

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@de-sec better bump to version 1.0, as a new Kimai major version is needed

@jens-2305 any plans to merge the changes / maintain that package? If not, I will link the repo of de-sec from the Store.

Bump Version
CHANGELOG.md Outdated
Comment on lines 7 to 9
## 0.9

migration to Kimai2 v2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 0.9
migration to Kimai2 v2
## 1.0
migration to Kimai 2.0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants