Skip to content

Conversation

@proski
Copy link

@proski proski commented May 24, 2019

*  StashBuildEnvironmentContributor: Pass environment variables to pipelines
   
   Add environment variables to every Run caused by StashCause even if it's
   not an instance of AbstractBuild.

Split from #69, as it's possible to set up a pipeline without relying on the environment variables provided by the plugin (although I would definitely recommend using sourceCommitHash to make sure the plugin tests what Bitbucket Server expects to be tested).

@proski
Copy link
Author

proski commented May 24, 2019

I've added unit tests. The first commit adds unit tests for the existing code. The second commit changes the main code and updates the unit tests for the new behavior.

Copy link

@jakub-bochenski jakub-bochenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just merge it independently since it doesn't require pipeline to work and improves the test coverage

@jakub-bochenski jakub-bochenski requested a review from jimklimov May 24, 2019 14:05
proski added 2 commits May 24, 2019 10:36
…ines

Add environment variables to every Run caused by StashCause even if it's
not an instance of AbstractBuild.
@proski
Copy link
Author

proski commented May 24, 2019

Fixed raw type warnings.

@jakub-bochenski jakub-bochenski merged commit db39375 into jenkinsci:master Jun 3, 2019
@proski proski deleted the pipeline-environment branch June 3, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants