Skip to content

StashBuildTrigger: Rename StashBuildTriggerDescriptor to DescriptorImpl #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakub-bochenski merged 1 commit into from
Jul 12, 2019
Merged

StashBuildTrigger: Rename StashBuildTriggerDescriptor to DescriptorImpl #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ public class StashBuildTrigger extends Trigger<Job<?, ?>> {

private transient StashPullRequestsBuilder stashPullRequestsBuilder;

@Extension
public static final StashBuildTriggerDescriptor descriptor = new StashBuildTriggerDescriptor();
@Extension public static final DescriptorImpl descriptor = new DescriptorImpl();

@DataBoundConstructor
public StashBuildTrigger(
Expand Down Expand Up @@ -229,8 +228,8 @@ public boolean getOnlyBuildOnComment() {
return onlyBuildOnComment;
}

public static final class StashBuildTriggerDescriptor extends TriggerDescriptor {
public StashBuildTriggerDescriptor() {
public static final class DescriptorImpl extends TriggerDescriptor {
public DescriptorImpl() {
load();
}

Expand Down
3 changes: 1 addition & 2 deletions src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTriggerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import org.mockito.junit.MockitoJUnitRunner;
import org.mockito.junit.MockitoRule;
import org.mockito.quality.Strictness;
import stashpullrequestbuilder.stashpullrequestbuilder.StashBuildTrigger.StashBuildTriggerDescriptor;

@RunWith(MockitoJUnitRunner.class)
public class StashBuildTriggerTest {
Expand All @@ -24,7 +23,7 @@ public class StashBuildTriggerTest {

@Test
public void check_getters() throws Exception {
StashBuildTriggerDescriptor descriptor = StashBuildTrigger.descriptor;
StashBuildTrigger.DescriptorImpl descriptor = StashBuildTrigger.descriptor;

// Field names from config.jelly
Iterable<String> properties =
Expand Down