StashRepository: Implement in terms of Job, not AbstractProject #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change startJob() to return Queue.Item. Adjust unit tests to get build
parameters directly from the return value of startJob().
Make the project field in unit tests a partial mock ("spy" in Mockito
parlance) to allow the build to be scheduled inside Jenkins code while
keeping control over its behavior.
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java
Show resolved
Hide resolved
jakub-bochenski
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the commits from #69 posted separately to facilitate review.
This change is inspired by the original PR by @rhencke, but it uses a different call to
ParameterizedJobMixIn.scheduleBuild2, the one called the "convenience method" and recommended for triggers. It takes care of the quiet period and makes it unnecessary to use any raw types in our code.https://javadoc.jenkins.io/jenkins/model/ParameterizedJobMixIn.html#scheduleBuild2-hudson.model.Job-int-hudson.model.Action...-
The unit tests have been changed as well. Mockito cannot intercept static method calls, but it can examine the resulting queue item and take the parameters from it.