implemented Attribute change Feature #49561#9
Open
genmad wants to merge 1 commit intojenkinsci:masterfrom
Open
implemented Attribute change Feature #49561#9genmad wants to merge 1 commit intojenkinsci:masterfrom
genmad wants to merge 1 commit intojenkinsci:masterfrom
Conversation
added Tests + implementation
Contributor
Author
|
Well, Need to investigate further why. Is it a windows problem, or is it an java api problem, is it a timing problem? Changed the status read and execute but windows didn't update to the changes. Who knows ... Any suggestions are welcome. @znerd sadly enough, my fears about this topic came true :(. On linux it seems to work, but on windows ... |
Contributor
|
It's now almost 4 years later, and apparently I missed the notification for this PR. In the mean time, I've moved on, and I don't have a use case for this feature anymore. Still, thanks a lot for the effort @genmad – and apologies for the late response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this pull request is just for @znerd to test if it fulfills his requirements, in the moment . When this is done, we can discuss if and how to enable configurability of the feature that file properties are checked too.
So no need to merge anything yet. I will ping Oleg when we are done.