Fix to allow --detect.excluded.directories to work correctly again with wildcards like v7#55
Open
isaac84 wants to merge 2 commits intojenkinsci:masterfrom
Open
Conversation
…th wildcards '*' like it used to in v7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't escape asterisk '*' in DetectScriptStrategy so wildcards can correctly work again for
--detect.excluded.directoriesSee https://community.synopsys.com/s/article/detect-excluded-directories-doesn-t-work
The workaround wasn't an option for us as unfortunately our repo is messy and there are about 100 directories that need to be excluded. Using a static list would be unmaintainable in our situation.
Testing done
Updated the existing DetectScriptStrategyTest to verify that '*' are not escaped, and tested this then allows the
--detect.excluded.directoriesoption to work correctly in our Jenkins builds (it does). Note: however we build with Linux so powershell was not tested in Jenkins.Submitter checklist