Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Winston from 2.x to 3.x #195

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/custom-api/session.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const passwordHelper = require('./password-helper')

const fs = require('fs')
const jwt = require('jsonwebtoken')
const logger = require('winston')
const logger = require('../logger')

function isSessionCreationEnabled () {
return config.getConf('authentication:type') === 'jwt'
Expand Down
2 changes: 1 addition & 1 deletion lib/custom-api/user.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

'use strict'
const logger = require('winston')
const logger = require('../logger')
const passwordHelper = require('./password-helper')

const FhirCommon = require('../fhir/common')
Expand Down
2 changes: 1 addition & 1 deletion lib/fhir/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/
'use strict'

const logger = require('winston')
const logger = require('../logger')

const FhirCommon = require('./common')
const Authorization = require('../security/authorization')
Expand Down
2 changes: 1 addition & 1 deletion lib/fhir/module-loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

const fs = require('fs')
const path = require('path')
const logger = require('winston')
const logger = require('../logger')

const fhirResources = {}

Expand Down
2 changes: 1 addition & 1 deletion lib/fhir/resources/binary.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
'use strict'

const mongodb = require('mongodb')
const logger = require('winston')
const logger = require('../../logger')

const FhirCommon = require('../common')
const FhirRoot = require('../root')
Expand Down
2 changes: 1 addition & 1 deletion lib/fhir/resources/patient.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

'use strict'
const logger = require('winston')
const logger = require('../../logger')

const config = require('../../config')
const FhirCommon = require('../common')
Expand Down
2 changes: 1 addition & 1 deletion lib/fhir/resources/practitioner.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

'use strict'

const logger = require('winston')
const logger = require('../../logger')

const FhirCommon = require('../common')
const QueryUtils = require('../query-utils')
Expand Down
2 changes: 1 addition & 1 deletion lib/fhir/root.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

const async = require('async')
const url = require('url')
const logger = require('winston')
const logger = require('../logger')

const FhirCommon = require('./common')
const FhirCore = require('./core')
Expand Down
2 changes: 1 addition & 1 deletion lib/fhir/services/matching-worker/matching-worker.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
'use strict'

const cp = require('child_process')
const logger = require('winston')
const logger = require('../../../logger')

module.exports = (mongo) => {
const startMatchingWorker = (context) => {
Expand Down
2 changes: 1 addition & 1 deletion lib/fhir/services/terminology-service.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

'use strict'
const logger = require('winston')
const logger = require('../../logger')
const FhirCommon = require('../common')

module.exports = (mongo) => {
Expand Down
11 changes: 0 additions & 11 deletions lib/init.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,3 @@

const path = require('path')
global.appRoot = path.join(path.resolve(__dirname), '..')

// Load configuration
const config = require('./config')

const logger = require('winston')
logger.remove(logger.transports.Console)
logger.add(logger.transports.Console, {
colorize: true,
timestamp: true,
level: config.getConf('logger:level')
})
21 changes: 21 additions & 0 deletions lib/logger.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
const config = require('./config')
const winston = require('winston')

const logger = winston.createLogger({
level: config.getConf('logger:level'),
format:
// Maintain the format from Winston 2.x.
winston.format.combine(
winston.format.colorize(),
winston.format.errors({ stack: true }),
winston.format.timestamp(),
winston.format.printf((info) => {
return `${info.timestamp} - ${info.level}: ${
info.stack == null ? info.message : info.stack
}`
})
),
transports: [new winston.transports.Console()]
})

module.exports = exports = logger
2 changes: 1 addition & 1 deletion lib/matching-queue/matching-queue.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
'use strict'

const cp = require('child_process')
const logger = require('winston')
const logger = require('../logger')

module.exports = (mongo) => {
const startWorker = (workers, workerName) => {
Expand Down
2 changes: 1 addition & 1 deletion lib/mongo.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
'use strict'
const MongoClient = require('mongodb').MongoClient
const config = require('./config')
const logger = require('winston')
const logger = require('./logger')

const collapseWhenSingleClause = (query) => {
const collapseOperatorsList = ['$and', '$or']
Expand Down
3 changes: 1 addition & 2 deletions lib/plugins/audit.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

'use strict'

const logger = require('winston')
const moment = require('moment')

const EVENT_OUTCOME = {
Expand All @@ -29,7 +28,7 @@ const excludedResourceTypeInteractions = [
}
]

module.exports = (mongo, fhirResources) => {
module.exports = (mongo, fhirResources, logger) => {
const fhirCore = require('../fhir/core.js')(mongo, fhirResources)

const getSuccessOrFailed = (data) => {
Expand Down
4 changes: 1 addition & 3 deletions lib/plugins/default.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@

'use strict'

const logger = require('winston')

module.exports = () => {
module.exports = (_mongo, _fhirResources, logger) => {
return {
userTypeRestrictions: {
'sysadmin': {
Expand Down
3 changes: 1 addition & 2 deletions lib/plugins/matching-queue.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,11 @@
'use strict'

const mongoDbQueue = require('mongodb-queue')
const logger = require('winston')

const matchingConfig = require('../../config/matching')
const constants = require('../constants')

module.exports = (mongo) => {
module.exports = (mongo, _fhirResources, logger) => {
return {
hooks: {
after: [
Expand Down
2 changes: 1 addition & 1 deletion lib/resource-linking.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/
'use strict'

const logger = require('winston')
const logger = require('./logger')

const FhirCommon = require('./fhir/common')
const constants = require('./constants')
Expand Down
2 changes: 1 addition & 1 deletion lib/security/authorization.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

'use strict'
const logger = require('winston')
const logger = require('../logger')
const FhirCommon = require('../fhir/common')

const userTypeRestrictions = {}
Expand Down
2 changes: 1 addition & 1 deletion lib/security/jwt-authentication/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const config = require('../../config')

const fs = require('fs')
const jwt = require('jsonwebtoken')
const logger = require('winston')
const logger = require('../../logger')

const TOKEN_PATTERN = /^ *(?:[Bb][Ee][Aa][Rr][Ee][Rr]) +([A-Za-z0-9\-._~+/]+=*) *$/

Expand Down
2 changes: 1 addition & 1 deletion lib/security/openhim-style-authentication.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

'use strict'
const logger = require('winston')
const logger = require('../logger')
const config = require('../config')
const crypto = require('crypto')
const FhirCommon = require('../fhir/common')
Expand Down
4 changes: 2 additions & 2 deletions lib/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
'use strict'
require('./init')

const logger = require('winston')
const logger = require('./logger')
const express = require('express')
const bodyParser = require('body-parser')
const xmlParser = require('express-xml-bodyparser')
Expand Down Expand Up @@ -73,7 +73,7 @@ if (validationConf.enabled) {

// Load plugins
fs.readdirSync(path.resolve(`${global.appRoot}/lib/plugins`)).forEach((file) => {
const plugin = require(`./plugins/${file}`)(mongo, fhirResources)
const plugin = require(`./plugins/${file}`)(mongo, fhirResources, logger)
if (plugin.userTypeRestrictions) {
authorization.addUserTypeRestrictions(plugin.userTypeRestrictions)
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"talisman": "^0.21.0",
"urijs": "^1.19.2",
"uuid": "^3.3.3",
"winston": "^2.4.2"
"winston": "^3.3.3"
},
"devDependencies": {
"chalk": "^2.4.1",
Expand Down
Loading