Skip to content

Conversation

@Gauvino
Copy link

@Gauvino Gauvino commented Jan 14, 2024

  • Changed emsdk version to the latest one from 2.0.34 to 3.1.51
  • Re-arranged the package
  • Added clean command

- Changed emsdk version to the latest one from 2.0.34 to 3.1.51
- Re-arranged the package
- Added clean command
@Gauvino
Copy link
Author

Gauvino commented Feb 6, 2024

image
Proof of building

@Gauvino
Copy link
Author

Gauvino commented Feb 29, 2024

@dmitrylyzo does this PR is needed or can be closed ?

The repo is abandoned ?

@dmitrylyzo
Copy link
Collaborator

I don't remember where I stopped.
IIRC, updating Emscripten to latest was causing JSO to not work in older browsers (TV).
Moreover, it requires more changes: master...dmitrylyzo:JavascriptSubtitlesOctopus:update-emscripten

The idea was to update this repo to upstream (as clean as possible, but without unnecessary changes).
One of those updates: #46

10.9 has moved to JASSUB, so this repo has become less relevant.

@Gauvino
Copy link
Author

Gauvino commented Feb 29, 2024

I don't remember where I stopped.

IIRC, updating Emscripten to latest was causing JSO to not work in older browsers (TV).

Moreover, it requires more changes: master...dmitrylyzo:JavascriptSubtitlesOctopus:update-

Ok, I didn't see this change.

The idea was to update this repo to upstream (as clean as possible, but without unnecessary changes).

One of those updates: #46

10.9 has moved to JASSUB, so this repo has become less relevant.

So this PR is not needed anymore if this repo is being used this jellyfin switch to jassub

@Gauvino Gauvino closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants