feat: add support for Flatpak #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolombier
commented
Jan 19, 2025
| @@ -1,3 +1,4 @@ | |||
| export const isWindows = process.platform === 'win32'; | |||
| export const isMacintosh = process.platform === 'darwin'; | |||
| export const isLinux = process.platform === 'linux'; | |||
| export const isFlatpak = !!process.env['FLATPAK_ID']; | |||
There was a problem hiding this comment.
There seems to be other envvar that could be used, let me know if you would like me to consolidate that
| @@ -163,6 +163,11 @@ export class RemoteSSHResolver implements vscode.RemoteAuthorityResolver, vscode | |||
| options = { shell: true, windowsHide: true, windowsVerbatimArguments: true }; | |||
| } | |||
|
|
|||
| if (isFlatpak) { | |||
| proxyArgs = ["--", "flatpak-spawn", "--host", "--env=TERM=xterm-256", proxyCommand, ...proxyArgs]; | |||
There was a problem hiding this comment.
Let me know if you would lime to use the TERM envvar defined locally if existing instead of forcing this xterm setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Codium installed via Flatpak without full flesystem access