Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2.6 & pycodestyle fix #149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Python 2.6 & pycodestyle fix #149

wants to merge 2 commits into from

Conversation

jayvdb
Copy link

@jayvdb jayvdb commented Jun 18, 2017

You can see the Python 2.6 build errors on #150 .
And on all builds, you can see it is installing attrs 17, not attrs 15 as pinned in requirements.txt

pip is not able to correctly manage constraints between invocations.
Python 2.6 is currently failing because tox installs the packages in
tox-requirements.txt and upgrades existing packages which were
pinned in requirements.txt (i.e. attrs)

In order to ensure the pinned versions are being tested, invoking
pip once with all constraints loaded is the most reliable method.
@jayvdb jayvdb mentioned this pull request Jun 18, 2017
@codecov-io
Copy link

codecov-io commented Jun 18, 2017

Codecov Report

Merging #149 into master will decrease coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   96.88%   96.57%   -0.31%     
==========================================
  Files          14       14              
  Lines        1635     1635              
==========================================
- Hits         1584     1579       -5     
- Misses         51       56       +5
Impacted Files Coverage Δ
ramlfications/config.py 100% <ø> (ø) ⬆️
ramlfications/utils.py 91.89% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a11cd...2944fae. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants