Use native byte order instead of little-endian.#12
Open
guerard wants to merge 1 commit intojdiamond:masterfrom
Open
Use native byte order instead of little-endian.#12guerard wants to merge 1 commit intojdiamond:masterfrom
guerard wants to merge 1 commit intojdiamond:masterfrom
Conversation
Per Google's documentation, the length of the message will be sent in the native byte-order, and so neither big nor little endianness can be assumed. This simply wraps the relevant read/write calls in an endianness check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Google's documentation, the length of the message
will be sent in the native byte-order, and so neither big
nor little endianness can be assumed. This simply wraps
the relevant read/write calls in an endianness check.