Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android Input Handling: Key Code 229 Not Captured #401

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

ashutosh2521
Copy link

@ashutosh2521 ashutosh2521 commented Dec 12, 2024

On Android devices, the timepicker widget fails to capture input values due to a limitation with virtual keyboards sending key code 229 instead of traditional key events. This results in the widget not updating properly or responding to user input.

Steps to Reproduce:

  1. Open the timepicker widget on an Android mobile device.
  2. Try to manually enter a time using the on-screen keyboard.
  3. Notice that the timepicker doesn't update or reflect the entered value.

Expected Behavior:
The widget should properly handle input events, including key code 229, which is used by Android's virtual keyboards.

Actual Behavior:
Input events triggered by key code 229 are not processed, preventing the widget from updating.

Proposed Solution:
Add an additional check for e.which === 229 in the widgetKeyup event handler to ensure that input events from Android devices are captured and processed correctly.

Additional Notes:

  • The issue only occurs on Android devices. The widget's behavior on iOS is unaffected.
  • I have attached a short video demonstrating the issue on Android devices for better context.
issue.of.Android.mobile.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants