Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 1 (fix imports)
On trying to import:
I got this error:
Which was fixed by adding '
melopy.
' to the start of each melopy import.Change 2 (fix tests)
The tests were still failing, I think this is because
key_to_note
was expecting integer division with/
. I have changed this to//
and the tests pass (and the results make sense). Additionally, had to movetests/melopy_tests.py
to top level (called ittests.py
).Change 3 (fix readme)
Fixes #63
Change 4
Added
__future__
statements to make compatible with Python 2.Thanks.