Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme major_scale example is wrong #63

Open
asteriskman7 opened this issue Apr 6, 2020 · 0 comments · May be fixed by #64
Open

Readme major_scale example is wrong #63

asteriskman7 opened this issue Apr 6, 2020 · 0 comments · May be fixed by #64

Comments

@asteriskman7
Copy link
Collaborator

The readme has an example that uses melopy.major_scale('C5') but there is no major_scale function. I think this should be something like melopy.generateScale('major', 'C5').

I will be happy to fix this if someone can confirm that I'm not just missing something.

If no one replies in a week or so I'll assume I'm right and make the change.
@frankharkins frankharkins linked a pull request Apr 12, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests, imports and readme frankharkins/Melopy
1 participant
@asteriskman7