Non-substantive changes per recommendations #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magic mirror > magicmirror2
michmich > magicmirror
superscript 2
remove axios dependency
axios > fetch
axios > fetch
This reverts commit c0defe5.
fetch.get > fetch
fetch.get > fetch
Add axios back (couldn't figure out how to get fetch working)
back to axios
Back to axios
This reverts commit 1bfefbe.
This reverts commit 09febe9.
This reverts commit 6945a6a.
This reverts commit 8b8b9ce.
This reverts commit 7fef05c.
This reverts commit a3806e7.
This reverts commit 073ba74.
This reverts commit 46dc422.
Add "Sport" keyword
remove trailing comma
```js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-substantive changes as recommended here https://github.com/KristjanESPERANTO/MagicMirror-3rd-Party-Modules/blob/main/result.md#MMM-MyScoreboard-by-jclarke0000
They also recommend the following:
axioscalls with a built-infetchfunction. I tried this but did not have success. Requires further investigation.Note: I do NOT recommend changing the branch name as recommended at this link because it will prevent
git pullupdating.I also noticed that, on
npm install, there is a warning that the packagecoffee-scripthad changed tocoffeescript, but I can't find where that package is referenced in the module.