Non-substantive changes per recommendations #84

dathbe · 2024-03-25T18:22:31Z

Non-substantive changes as recommended here https://github.com/KristjanESPERANTO/MagicMirror-3rd-Party-Modules/blob/main/result.md#MMM-MyScoreboard-by-jclarke0000

They also recommend the following:

Replacing the axios calls with a built-in fetch function. I tried this but did not have success. Requires further investigation.
Adding an ESLint configuration

Note: I do NOT recommend changing the branch name as recommended at this link because it will prevent git pull updating.

I also noticed that, on npm install, there is a warning that the package coffee-script had changed to coffeescript, but I can't find where that package is referenced in the module.

magic mirror > magicmirror2

michmich > magicmirror

superscript 2

remove axios dependency

axios > fetch

This reverts commit c0defe5.

fetch.get > fetch

Add axios back (couldn't figure out how to get fetch working)

back to axios

Back to axios

This reverts commit 1bfefbe.

This reverts commit 09febe9.

This reverts commit 6945a6a.

This reverts commit 8b8b9ce.

This reverts commit 7fef05c.

This reverts commit a3806e7.

This reverts commit 073ba74.

This reverts commit 46dc422.

Add "Sport" keyword

remove trailing comma

```js

replace

add logging

move logic back to node_helper

simplify logic

fix logic

flip logic

clean up code

WAS > WSH

add time limit to YD notification update

remove some logging

Update API endpoint for SNET provider

Always show today

filter by date

Update SNET.js

Clean up instructions, change from jclarke to dathbe

link to jclarke

Update ESPN.js to filter games based on date

dathbe added 30 commits March 25, 2024 10:24

Update MMM-MyScoreboard.js

74a1960

magic mirror > magicmirror2

Update README.md

56dd8bc

michmich > magicmirror

Update package.json

2f461af

superscript 2

Update package.json

46dc422

remove axios dependency

Update ESPN.js

073ba74

axios > fetch

Update SNET.js

a3806e7

axios > fetch

Delete package-lock.json

c0defe5

Revert "Delete package-lock.json"

0820acc

This reverts commit c0defe5.

Update ESPN.js

7fef05c

fetch.get > fetch

Update SNET.js

8b8b9ce

fetch.get > fetch

Update package.json

6945a6a

Add axios back (couldn't figure out how to get fetch working)

Update ESPN.js

09febe9

back to axios

Update SNET.js

1bfefbe

Back to axios

Revert "Update SNET.js"

6168091

This reverts commit 1bfefbe.

Revert "Update ESPN.js"

7e360e2

This reverts commit 09febe9.

Revert "Update package.json"

6d09c1c

This reverts commit 6945a6a.

Revert "Update SNET.js"

ab9dd1e

This reverts commit 8b8b9ce.

Revert "Update ESPN.js"

a52e3ee

This reverts commit 7fef05c.

Revert "Update SNET.js"

1605a90

This reverts commit a3806e7.

Revert "Update ESPN.js"

43a581f

This reverts commit 073ba74.

Revert "Update package.json"

d2bcbb6

This reverts commit 46dc422.

Update package.json

330d66b

Add "Sport" keyword

Update package.json

6a70c3e

remove trailing comma

Update README.md

78e8cc9

```js

Add files via upload

74ce61a

Update ESPN.js

920e918

replace

Update SNET.js

93cf34b

replace

Add files via upload

d64b32e

Update MMM-MyScoreboard.js

dcbb847

replace

Update node_helper.js

9415f04

replace

dathbe and others added 30 commits May 15, 2024 11:57

Update README.md

f2706f8

Update README.md

e9a0480

Update node_helper.js

dc48598

add logging

Update node_helper.js

13ed5bc

Update node_helper.js

763542e

move logic back to node_helper

Update MMM-MyScoreboard.js

2bd47d5

move logic back to node_helper

Update node_helper.js

71c1a1a

simplify logic

Update MMM-MyScoreboard.js

61393d5

simplify logic

Update MMM-MyScoreboard.js

b4cc3af

fix logic

Update node_helper.js

00968f8

flip logic

Update MMM-MyScoreboard.js

5827115

Update MMM-MyScoreboard.js

abe30e9

clean up code

Update MMM-MyScoreboard.js

3becc35

Update README.md

78f10e6

WAS > WSH

Update MMM-MyScoreboard.js

583ccdf

Update MMM-MyScoreboard.js

b412661

add time limit to YD notification update

Update node_helper.js

7c79a4f

Update MMM-MyScoreboard.js

a5291c3

Update node_helper.js

9433782

Update node_helper.js

25ded1b

remove some logging

Update node_helper.js

70bf956

remove some logging

Update node_helper.js

1a27100

remove some logging

Update SNET.js

5c9b6c7

Update API endpoint for SNET provider

Merge pull request #5 from dathbe/alwaysShowToday

b814354

Always show today

Update ESPN.js

ad0735c

filter by date

Merge pull request #1 from zaccoffey/patch-1

b43e28d

Update SNET.js

Update SNET_YD.js

88c1537

Update README.md

bae3d99

Clean up instructions, change from jclarke to dathbe

Update README.md

fe0655a

link to jclarke

Merge pull request #9 from dathbe/filterBowl

b8900aa

Update ESPN.js to filter games based on date

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Non-substantive changes per recommendations #84

Non-substantive changes per recommendations #84

dathbe commented Mar 25, 2024 •

edited

Loading

Non-substantive changes per recommendations #84

Are you sure you want to change the base?

Non-substantive changes per recommendations #84

Conversation

dathbe commented Mar 25, 2024 • edited Loading

dathbe commented Mar 25, 2024 •

edited

Loading