Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSL Context per connection #180

Closed
wants to merge 8 commits into from

Conversation

joris-lambrechts
Copy link

I opted to add another parameter to the Wire.send method although the list of parameters is too high. I ran the same test from the issue with the TrustedWire and got the same result as previous without it so that's good enough for me.

Any feedback is welcome.

#178

@0crat
Copy link

0crat commented May 25, 2019

@yegor256/z please, pay attention to this pull request

@0crat 0crat added the scope label May 25, 2019
@0crat
Copy link

0crat commented May 25, 2019

Job #180 is now in scope, role is REV

@0crat
Copy link

0crat commented May 25, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@joris-lambrechts
Copy link
Author

assign @yegor256

@0crat
Copy link

0crat commented May 30, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jun 5, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jun 10, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jun 15, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jun 20, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jun 25, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jun 30, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@yegor256
Copy link
Member

yegor256 commented Jul 4, 2019

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 4, 2019

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Jul 4, 2019

@rultor merge

@joris-lambrechts @yegor256 Oops, I failed. You can see the full log here (spent 6min)

	at com.jcabi.http.request.JdkRequest$1.createConnection(JdkRequest.java:134)
	at com.jcabi.http.request.JdkRequest$1.send(JdkRequest.java:97)
	... 24 more


Tests run: 11, Failures: 2, Errors: 0, Skipped: 0

[INFO] 
[INFO] --- maven-failsafe-plugin:2.19:verify (default) @ jcabi-http ---
[INFO] Failsafe report directory: /home/r/repo/target/failsafe-reports
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:39 min
[INFO] Finished at: 2019-07-04T12:18:02+00:00
[INFO] Final Memory: 43M/383M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.19:verify (default) on project jcabi-http: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.19:verify (default) on project jcabi-http: There are test failures.

Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
	at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:91)
	at org.apache.maven.plugin.failsafe.VerifyMojo.execute(VerifyMojo.java:202)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
	... 20 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
container b36826774de18fe7b6fcd59e9bf54a06fc2b4f52b568be7624636477adec28dd is dead
Thu Jul  4 14:19:06 CEST 2019

@yegor256
Copy link
Member

yegor256 commented Jul 4, 2019

@joris-lambrechts there are some failures in the build. Are you sure it works?

@0crat
Copy link

0crat commented Jul 5, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 10, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 15, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 20, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 25, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 30, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 4, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 9, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 14, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 19, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 24, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@yegor256
Copy link
Member

@joris-lambrechts are you going to fix the branch or we close this?

@0crat
Copy link

0crat commented Oct 14, 2019

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

final int connect, final int read,
final SSLContext context) throws IOException {
final SSLContext resolvedContext;
if (context == null) {
Copy link
Collaborator

@andreoss andreoss Jun 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joris-lambrechts On the other hand, it seems to me now that in TrustedWire (which should disable SSL verification) we should disregard incoming context completely and replace it with one which comes from context() method.
Also it appears that the whole feature of injection SSLContext could be done with Wire instead of adding a method to Request.

request.through(SecureWire.class, sslcontext).fetch()

But the decision is @yegor256's

@0crat
Copy link

0crat commented Jun 29, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 4, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 13, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 18, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 23, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 29, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 3, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 8, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 13, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 18, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@andreoss
Copy link
Collaborator

andreoss commented Sep 6, 2020

@joris-lambrechts @yegor256
This PR will add an extra parameter to Wire#send, and a extra method to Request,
I believe there is a simpler solution to the problem: #223
Regaring
#180 (comment), passing SSLContext via Wire is impossible, because only initial Wire can take an advantage of SSLContext.

@0crat
Copy link

0crat commented Sep 7, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Sep 12, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Sep 18, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Sep 23, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Sep 28, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Oct 3, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Oct 8, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Oct 13, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Oct 18, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Oct 23, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Nov 2, 2020

@yegor256/z everybody who has role REV is banned at #180; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@andreoss
Copy link
Collaborator

Closing for being old.

@andreoss andreoss closed this Jun 26, 2021
@0crat
Copy link

0crat commented Jun 26, 2021

Job gh:jcabi/jcabi-http#180 is not assigned, can't get performer

@0crat
Copy link

0crat commented Jun 26, 2021

Pull request #180 was not merged, no payment for ARC, see §28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants