Add support for .cdxml and .mof
#32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Plant <[email protected]>
Owner
|
Thanks for this, would you be interested in adding some tests or ok with me committing on top of this PR to add them? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
===========================================
+ Coverage 46.52% 63.60% +17.07%
===========================================
Files 25 25
Lines 1829 2011 +182
Branches 206 205 -1
===========================================
+ Hits 851 1279 +428
+ Misses 839 662 -177
+ Partials 139 70 -69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tom Plant <[email protected]>
Contributor
Author
|
Thanks! Took a break for BSides Canberra, but I've added a MOF test now. Looks like they're mostly used for DSC resources. On some test devices, the MOFs for in-box features and drivers were all catalog signed |
jborean93
approved these changes
Sep 30, 2025
Owner
|
Thanks for working on this change and adding the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reversing
pwrshsip.dlland noticed it supported.cdxmland.mof, so thought I might as well send a PR. Thanks for the great module!