Add better error for invalid Azure endpoint #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a better error message when `Get-OpenAuthenticodeAzTrustedSigner` is used with an `-Endpoint` that is not one of the well known endpoint identifiers or not an absolute URI. Without this the error message from the Azure SDK is not very easy to understand.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
===========================================
+ Coverage 46.14% 63.41% +17.26%
===========================================
Files 25 25
Lines 1818 2001 +183
Branches 205 206 +1
===========================================
+ Hits 839 1269 +430
+ Misses 847 659 -188
+ Partials 132 73 -59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a better error message when
Get-OpenAuthenticodeAzTrustedSigneris used with an-Endpointthat is not one of the well known endpoint identifiers or not an absolute URI. Without this the error message from the Azure SDK is not very easy to understand.