Refactor key operations #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
===========================================
+ Coverage 37.83% 62.94% +25.10%
===========================================
Files 23 24 +1
Lines 2051 1951 -100
Branches 255 197 -58
===========================================
+ Hits 776 1228 +452
+ Misses 1225 665 -560
- Partials 50 58 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Refactor the key operations to use common code and try and reduce the complexity of implementing custom key providers. This also removes the SslDotCom key provider due to lack of use and testing available for that provider.
jborean93
force-pushed
the
key-refactor
branch
from
5da533a to
46ec369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the key operations to use common code and try and reduce the complexity of implementing custom key providers. This also removes the SslDotCom key provider due to lack of use and testing available for that provider.