Created new PR for pull 54. Added extra test as requested.#103
Open
JayBaileyCS wants to merge 29 commits intojbloomAus:mainfrom
Open
Created new PR for pull 54. Added extra test as requested.#103JayBaileyCS wants to merge 29 commits intojbloomAus:mainfrom
JayBaileyCS wants to merge 29 commits intojbloomAus:mainfrom
Conversation
Owner
|
@JayBaileyCS should I accept this or wait per the changes we discussed? (moving away from git-lfs) |
Contributor
Author
|
I would wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged the old PR in and added a new test.
Ensured acceptance and unit tests pass. Added additional test as requested in #54 to test that the correct number of checkpoints were made, the last checkpoint was equal to the model, and the first checkpoint was not equal to the model.