fix: refuse malformed MCP quote data - #7
Open
kkkhs wants to merge 1 commit into
Open
Conversation
jbisaccia-9
marked this pull request as ready for review
September 4, 2026 15:21
Owner
|
Thanks for contributing! This is a solid fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Closes #4. Malformed MCP quote payloads now fail closed as missing quotes instead of raising out of the connector. The toy MCP server can emit bad quote data, and the regression test asserts quote-sanity refuses the order.
Why?
Unparseable quote data should stop an order at the existing quote-sanity gate rather than escaping the gate stack as a connector exception.
Checklist